-
Notifications
You must be signed in to change notification settings - Fork 0
test: add e2e tests with localstack for all scanners, and make summarization stuff work #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdds a Summarization protobuf/gRPC API and Python FastAPI AI microservice with LLM integration, Go gRPC client and service wiring, GraphQL schema/resolver extensions, LocalStack-based E2E infra and tests, buf tooling and generation configs, and supporting build/test automation and generated code. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as GraphQL Client
participant API as Backend API (GraphQL)
participant Svc as Security Service
participant Coord as Scanner Coordinator
participant Scanner as Service Scanner
participant SumCli as Summarization Client (Go)
participant AI as AI Service (gRPC)
participant LLM as LLM Provider
Client->>API: StartScan(accountID, services, regions)
API->>Svc: Scan(ctx, config)
Svc->>Coord: Coordinator.Scan()
Coord->>Scanner: Scanner.Scan()
Scanner-->>Coord: []Finding
Coord-->>Svc: ScanResult
alt summarization enabled and failures exist
Svc->>SumCli: SummarizeFindings(scanID, accountID, findings)
SumCli->>AI: gRPC SummarizeFindings(Request)
AI->>LLM: prompt -> completion
LLM-->>AI: summary & commands
AI-->>SumCli: SummarizeFindingsResponse
SumCli-->>Svc: SummaryResult
Svc->>Svc: convertSummaryResult -> attach to ScanResultWithSummary
end
Svc-->>API: ScanResultWithSummary
API-->>Client: Scan { findings, summary }
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45–75 minutes
Poem
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Free 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 23584316 | Triggered | Generic Password | 7bcee4f | backend/api/e2e/lambda_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
…rfile Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Signed-off-by: Karan <karanlokchandani@protonmail.com>
c6700a9 to
d312157
Compare
Signed-off-by: Karan <karanlokchandani@protonmail.com>
Summary by CodeRabbit
New Features
Infrastructure
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.