blotting in lv3, flags for blotting + drizzling#172
Merged
akleroy merged 2 commits intoPhangsTeam:mainfrom Apr 2, 2026
Merged
Conversation
Collaborator
|
Happy to be overridden on this, but I would rather have 2 parameters, do_drizzle and do_blot, where is do_blot is True when do_drizzle is False throws up a warning that do_blot needs to be set True. Just think that's neater And please add some description to docs/steps/lv3.rst!!! |
Author
|
@thomaswilliamsastro Done! |
akleroy
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #165 we added some lines at the end of Lv3Step to drizzle all of the individual exposures to the WCS of the mosaic.
This PR adds a flag to be able to skip that (since it produces a lot of files that not everyone wants), and it is now skipped by default.
Here we also add the ability to blot the aforementioned drizzled exposures back to the detector frame of some reference exposure. By default this is the first exposure in the list (alphabetically sorted). This requires drizzled exposures in order to work, and is turned off by default. The flag here is
do_drizzle_and_blot.End-to-end run on a test case with
do_drizzle_and_blot=trueworked for me. Anddo_drizzleworked before this update.Example snippet of
config.toml: