Draft
Conversation
FslashN
reviewed
Mar 20, 2026
| /datum/overmap/ship/controlled/proc/get_faction_techweb(datum/faction/faction_datum) | ||
| if(!faction_datum) | ||
| return null | ||
|
|
Contributor
There was a problem hiding this comment.
You could add faction tag to each datum as a string, then initial() the variable without having to initialize/create the actual datum. Then pass the tag through a switch() instead of doing the if() chain and istype() checking.
I think it looks something like this, though it's been a bit since I've looked at the actual syntax:
var/datum/faction/this_faction = faction_datum
var/faction_tag = initial(faction_datum.faction_tag)
Collaborator
Author
There was a problem hiding this comment.
Ill be totally honest I did most of this draft stuff back in December but then started my modular ruin stuff.
I have not even really sat down to start testing it.
Really I just made it a PR since I never published it to my fork, and was probably going to lose it if I didnt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
December 17, 2025
This was my working branch and notes for the factional R&D system.
It is highly volatile and will probably not pass any tests.
Why It's Good For The Game
Changelog
🆑
/:cl: