Skip to content

[TM-ABLE] Crafting blacklist#634

Open
Ossa88 wants to merge 5 commits intoPentestSS13:masterfrom
Ossa88:crafting-blacklist
Open

[TM-ABLE] Crafting blacklist#634
Ossa88 wants to merge 5 commits intoPentestSS13:masterfrom
Ossa88:crafting-blacklist

Conversation

@Ossa88
Copy link
Copy Markdown
Collaborator

@Ossa88 Ossa88 commented Mar 20, 2026

About The Pull Request

Originally Finished: Feb 15, 2026

Corrects the Blacklist system on hand crafting systems.
The system currently already has a blacklist, but the system is still able to look down path for valid objects.

For example:
A blackmarket_uplink wants an obj/item/radio
blackmarket_uplink is told that obj/item/radio/headset is blacklisted. It will never be consumed.
blackmarket_uplink could use a obj/item/radio/headset/alt or any other subtype as the orginal blacklist was to a particular path.

This corrects the system by enforcing a hard path lock if a blacklist is defined.
This does allow a whitelist if a object inside a hard path locked blacklist should be useable, very niche condition only added to cover all bases.

Changelog

🆑
fix: Allows individual crafting recipes to ignore certain subpathed blacklisted items
/:cl:

@Ossa88 Ossa88 requested a review from Constellado as a code owner March 20, 2026 02:04
@Ossa88 Ossa88 linked an issue Mar 20, 2026 that may be closed by this pull request
@Ossa88 Ossa88 changed the title [DRAFT] Crafting blacklist [TM-ABLE] Crafting blacklist Mar 20, 2026
@Ossa88 Ossa88 added Test Merge Required This requires Test Merging Bug Fix TM Candidate This PR is approved for TM Modularization Requested Additional Modularization might be required/requested or fixes to modularization. Review Request - Code For PR's that require Code Review labels Mar 20, 2026
@Ossa88
Copy link
Copy Markdown
Collaborator Author

Ossa88 commented Mar 20, 2026

I know that this needs modularization. Ill update that at the end since I am still cleaning out all my random branches.

@ParboleumLoyce
Copy link
Copy Markdown

Advanced Translation Gloves don't blacklist your headset.

Not sure if this is supposed to be fixed, but it definitely isn't.

@Ossa88
Copy link
Copy Markdown
Collaborator Author

Ossa88 commented Mar 22, 2026

Advanced Translation Gloves don't blacklist your headset.

Not sure if this is supposed to be fixed, but it definitely isn't.

I learned after the fact that what I did was prevent them from being allowed to start the crafting.

The actual deletion code was located elsewhere and never respected the blacklist shiptest wrote originally.

I updated the code and tested it and it should work during the next round (if the tm gets updated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Code Change Modularization Requested Additional Modularization might be required/requested or fixes to modularization. Review Request - Code For PR's that require Code Review Test Merge Required This requires Test Merging TM Candidate This PR is approved for TM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crafting prioritises using headset radio over shortwave radio

2 participants