Open
Conversation
Collaborator
Author
|
I know that this needs modularization. Ill update that at the end since I am still cleaning out all my random branches. |
|
Advanced Translation Gloves don't blacklist your headset. Not sure if this is supposed to be fixed, but it definitely isn't. |
Collaborator
Author
I learned after the fact that what I did was prevent them from being allowed to start the crafting. The actual deletion code was located elsewhere and never respected the blacklist shiptest wrote originally. I updated the code and tested it and it should work during the next round (if the tm gets updated) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Originally Finished: Feb 15, 2026
Corrects the Blacklist system on hand crafting systems.
The system currently already has a blacklist, but the system is still able to look down path for valid objects.
For example:
A blackmarket_uplink wants an
obj/item/radioblackmarket_uplink is told that
obj/item/radio/headsetis blacklisted. It will never be consumed.blackmarket_uplink could use a
obj/item/radio/headset/altor any other subtype as the orginal blacklist was to a particular path.This corrects the system by enforcing a hard path lock if a blacklist is defined.
This does allow a whitelist if a object inside a hard path locked blacklist should be useable, very niche condition only added to cover all bases.
Changelog
🆑
fix: Allows individual crafting recipes to ignore certain subpathed blacklisted items
/:cl: