Skip to content

[EMERGENCY FIX] Fixes Splash Trickwines#631

Open
Ossa88 wants to merge 1 commit intoPentestSS13:masterfrom
Ossa88:splash-trickwine-fix
Open

[EMERGENCY FIX] Fixes Splash Trickwines#631
Ossa88 wants to merge 1 commit intoPentestSS13:masterfrom
Ossa88:splash-trickwine-fix

Conversation

@Ossa88
Copy link
Copy Markdown
Collaborator

@Ossa88 Ossa88 commented Mar 19, 2026

About The Pull Request

Trickwine's have an additional function of being harmful splash potions.

But due to an oversight, the on_creation proc was never passing on a duration to the status effects system. This resulted in the status effect using the default value of INFINITE.

Depending on the Trickwine being used, this could result in a Round Removal which could only be corrected by admin var editing the affected player.

Technical Details:

Step 1: Trickwine is Thrown on Mob
Step 2: expose_mob proc is called

  • Proc determines method of exposure
  • Proc applies status effects
    • What debuff effect
    • Who to apply it to
    • How long to apply
  • Proc hands this information to on_creation proc

Step 3: on_creation collects the data

  • What debuff effect
  • who to apply it to
  • on_creation applies the debuff to target.

The problem. The expose_mob proc calculated the duration but never handed it over to the on_creation. Since on_creation never had this information it uses its predefined varible of INFINITE.

Fix:
Step 3: on_creation collects the data

  • What debuff effect
  • who to apply it to
  • sets debuff duration based on expose_mob calculation
  • on_creation applies the debuff to target for the debuff duration.

Why It's Good For The Game

Splash Trickwine's are no longer so overpowered that they could round removal players.

Changelog

🆑
fix: Trickwines will now correctly apply debuffs
/:cl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant