[EMERGENCY FIX] Fixes Splash Trickwines#631
Open
Ossa88 wants to merge 1 commit intoPentestSS13:masterfrom
Open
[EMERGENCY FIX] Fixes Splash Trickwines#631Ossa88 wants to merge 1 commit intoPentestSS13:masterfrom
Ossa88 wants to merge 1 commit intoPentestSS13:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Trickwine's have an additional function of being harmful splash potions.
But due to an oversight, the on_creation proc was never passing on a duration to the status effects system. This resulted in the status effect using the default value of INFINITE.
Depending on the Trickwine being used, this could result in a Round Removal which could only be corrected by admin var editing the affected player.
Technical Details:
Step 1: Trickwine is Thrown on Mob
Step 2: expose_mob proc is called
Step 3: on_creation collects the data
The problem. The expose_mob proc calculated the duration but never handed it over to the on_creation. Since on_creation never had this information it uses its predefined varible of INFINITE.
Fix:
Step 3: on_creation collects the data
Why It's Good For The Game
Splash Trickwine's are no longer so overpowered that they could round removal players.
Changelog
🆑
fix: Trickwines will now correctly apply debuffs
/:cl: