Open
Conversation
d7e08e7 to
79b874d
Compare
79b874d to
7ae7eae
Compare
Collaborator
|
I would love to have this one solved, but I would like to hear @PedroBern 's opinion on it first. @PabloCastellano how can I test this best? |
Author
|
@pors Try it: |
17d38f2 to
7ae7eae
Compare
Collaborator
|
I can't get it to work for Django 4 (which is the only reason for me to upgrade django-graphql-jwt>=0.3.2). It does work for 0.3.1, but that doesn't work with Django 4. Sorry, but I think it is best to abandon this project and find an alternative. |
4 tasks
|
for me this branch works with
|
Collaborator
|
I still think this PR will break things for people. See #23. It doesn't say there what the actual incompatibility is though. Can someone help out there? @joshuachinemezu @PedroBern @ulgens @panosangelopoulos ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #121, #116, #45
Fixes #111, #133 and #146