Skip to content

Conversation

@chedieck
Copy link
Collaborator

@chedieck chedieck commented Jun 20, 2025

Related to #505

Description

Fixes #505.

Test plan

  1. Move paybutton-config.json to react/lib/paybutton-config.json.
  2. Then, inside react/, run yarn build.
  3. Make sure the react/dist/ directory tree is being built like:
dist/
├── index.d.ts
├── index.js
├── index.js.map
├── index.modern.js
├── index.modern.js.map
├── lib
│   ├── altpayment
│   ├── assets
│   ├── components
│   ├── tests
│   ├── themes
│   └── util
└── src
    ├── App.d.ts
    └── main.d.ts

... not having a react/dist/react folder there.

Also, I added a new github action to check that, so that should be automatic from now on.

@chedieck chedieck force-pushed the fix/react-build-dist-declaration-file branch 4 times, most recently from 6bd5e38 to f8afcde Compare June 20, 2025 11:46
wip

wip

fix: react deps & checkout
@chedieck chedieck force-pushed the fix/react-build-dist-declaration-file branch 2 times, most recently from cbda9c1 to 96511f7 Compare June 20, 2025 12:17
chedieck added 5 commits June 20, 2025 09:31
wip

wip

wip

wip

WIP
This reverts commit dcaef32.
@chedieck chedieck force-pushed the fix/react-build-dist-declaration-file branch from 517e554 to 4ea8537 Compare June 20, 2025 12:32
@Klakurka Klakurka self-requested a review June 20, 2025 19:28
@Klakurka Klakurka merged commit cd9b410 into master Jun 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improper building of dist/

3 participants