-
Notifications
You must be signed in to change notification settings - Fork 16
[#300] feat: keep socket open on closed button #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d2730e to
9f6c90a
Compare
|
It is not working properly, I was able to trigger the payment success behavior once but the other times I tried I can only hear the sound the dialog doesn't open |
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make a decision around how to handle the user clicking multiple buttons on the page before paying.
If I open one button dialog, close it, then open a 2nd different one and pay to that, the first one will open up on top of my active button dialog.
One option is to only ever keep the last connection open. If somebody opens a new dialog, kill the old one.
Another option is to continue having it work as-is but if I pay to button #2, don't trigger #1 to open in my face.
Either option is good with me.
|
Conflicts. |

Related to #300
Description
Changes the logic in order to make the
onSuccessfunction still fire for a closed PayButton, as long as it has been opened once since page load.Test plan
Make sure not only #300 is working well, but also sideshift altpayments & Widgets, since the changes also affect them.