Skip to content

Conversation

@johnkuney
Copy link
Collaborator

Related to #442

Description

  • Prevent non numerics in the input
  • Improved copy buttons and shift value displays
  • style tweaks
  • improve outer gray box jumping around. This one was is kind of tricky due to some of the widget's responsive size definitions for the qr inner content, which is not present here. So its better, but not perfect
    Test plan

preview and try out a shift

@Klakurka Klakurka requested review from Klakurka and chedieck January 14, 2025 05:56
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we somehow ensure that the widget/dialog height remains the same throughout the wizard? Right now, it jumps on each step.
  • Can we add some hover animation on the copy buttons?
  • I still kinda feel like this should be more "button-y"
    image

@johnkuney
Copy link
Collaborator Author

okay for sure, added those

Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The dialog height jumping is better but not perfect. We can improve this in a different PR; not high prio.
  • If you go to start a shift w/ an editable amount then back out, the 'Edit amount' field will have a ton of extra decimals in there... XEC only supports 2 so I'm not sure where they're coming from:
    image Notice how the QR code and 'Send' text at the top are fine.

@johnkuney
Copy link
Collaborator Author

hmm yes I'm seeing the same, and actually it will let you enter more than two decimals at any point, as well as non numeric characters...

I can see the value it's using, but not sure the best way to fix this. Either way it should probably be handled in another PR. And I think @lissavxo or @chedieck may have a better idea the best way to handle it

Its using the "thisamount" value which is not run through the getCurrencyObject function which has some formatting rules based on the currency...I imagine the naked state was used for rendering reasons perhaps?...but seems like the handleAmountChange function could be improved to sanitize the value more

@Klakurka Klakurka merged commit 385ef4b into master Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants