fix: sideshift fixed amount #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
previously approved these changes
Dec 8, 2024
chedieck
dismissed
Klakurka’s stale review
The merge-base changed after approval.
Klakurka
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Description
Fix issue where a paybutton with a fixed amount wouldn't display the "Don't have any XEC?" option.
Test plan
e.g: a XEC PayButton created with the parameter
amount=300000wouldn't display the option to use sideshift. In this branch it should.Note: the amount should be more then what would be equivalent to 10 USD, or it shouldn't appear anyway.