-
Notifications
You must be signed in to change notification settings - Fork 16
Fix/disabled behavior #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
775a9ac to
65c43b2
Compare
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some "interesting" behavior depending on what settings you go with but this is fine IMO.
| <Typography className={errorMsg ? classes.error : classes.text}> | ||
| {errorMsg | ||
| ? errorMsg | ||
| : disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe some parenthesis and indentation here to make it more readable? The change makes the beginning more readable, but the part in the middle is quite hard to follow
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
chedieck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, the described behavior applies therefore I'm approving, but:
Why are we blurring the disabled button but not the dialog? I actually don't understand the purpose of the "open payment dialog" (which was already present on master), AFAICT it acts just like a PayButton.
The merge-base changed after approval.
The merge-base changed after approval.
chedieck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK why this dismissal is happening, approving again
The merge-base changed after approval.
dc657bf to
f262a66
Compare
Related to #427
Description
Fixed disabled behavior following this instructions
Test plan
Run the project with
yarn devoryarn clean:buildUsing the generator
1 - Create a button active disabled option, the button text should be blurred
2 - Create a widget active disabled option, the widget and button text should be blurred
3 - Create a widget active disabled option, add goal amount, the goal amount bar should be blurred too
4 - Test open dialog buttons in the
dev/demo/index.htmlthere are two buttons and one is disabled, the disabled button should not open the dialog and the text should change to unavailable when click