-
Notifications
You must be signed in to change notification settings - Fork 16
Fix/op return fail #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/op return fail #435
Conversation
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rebase to master.
- Can we add this (OP_RETURN msg) to the button generator?
chedieck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior described in the test plan checks out, however, the issue mentions reverting the text back, not getting ridding of it and using the console.
I don't think showing the error in the console only is a good idea, I think we should display that same text of before but having it cleared out after 5s (as we do in other places).
The color could be red to indicate an error, too.
4e70c27 to
eeac02b
Compare
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a few seconds, the text at the top changes from the red error to "send any amount":
I get that this is kinda out of scope and related to #327 but IMO we should just deal with this now. Up to you if you want to do it in this branch or a new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a few seconds, the text at the top changes from the red error to "send any amount":
I thought this was the desired behavior, as per the issue description.
In any case, I also think is better to leave the error there.
The merge-base changed after approval.
It's referring to when the widget is regenerated. |
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can improve the error message at some point as the wording is pretty technical but it's fine for now.
The merge-base changed after approval.
The merge-base changed after approval.
434016d to
e26445e
Compare

Related to #426
Description
Fix opReturn fail behavior
Test plan
create a button/widget with
op-returnprop set to a large string like this:"ABCDEFGHIJKLMNOPABCDEFlkfdnlkfndlksnkjsnfkldsnlknlksssssssss;sssssssssGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOP"the expected behavior is blur QR code and show the error message in console instead of in the button text.