chore: realocate, rename, uncommit config #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
requested changes
Nov 13, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
Seems to work but there's a test failure.
Klakurka
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Realocates the config file to the root dir, so it's not hidden in a place that has to be memorized (it was in
react/libbefore).Also changes its name from
config.jsontopaybutton-config.jsonand leaves it gitignored. An additional file calledexample-config.jsonwas added too, also to the root directory.Test plan
Just run
yarn dev, the example config should be copied to the new expected location./paybutton-config.jsonand then the software should run as always.