Feat/contribution offset prop #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
requested changes
Nov 11, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
- Readme needs updating as you said.
- Can you add this into
paybutton-generator.html?
|
|
||
| <div class="paybutton" to="ecash:qrmm7edwuj4jf7tnvygjyztyy0a0qxvl7quss2vxek" goal-amount="2500.05" currency="USD" | ||
| text="Donate (other dev)" on-success="mySuccessFunction" on-transaction="myTransactionFunction"></div> | ||
| text="Donate (other dev)" on-success="mySuccessFunction" on-transaction="myTransactionFunction" enable-altpayment="false"></div> |
Member
There was a problem hiding this comment.
Can you rebase to the branch hat hasn't been merged yet?
We should have at least 1 contributionOffset example here.
lissavxo
force-pushed
the
feat/contribution-offset-prop
branch
from
94ac9cc to
904fb14
Compare
Klakurka
approved these changes
Nov 13, 2024
chedieck
approved these changes
Nov 13, 2024
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
looks good, though it also works for negative numbers (don't know if this is should be expected, but I think it's okay so I am approving)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #425
Description
Added a new prop called contributionOffset.
Test plan
Create a paybutton or widget and add prop goalAmount and contributionOffset, it should work as described here
Also test without the prop to make sure it works without it.