feat:enable altpayment prop #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
requested changes
Nov 7, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
Can you add an entry into the docs? All 3 langs.
Klakurka
requested changes
Nov 7, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
On the Chinese docs, the desc format is different from what we have on the other properties:
Can you use the same tags & quotes as we're using on the other ones to keep them consistent?
Klakurka
approved these changes
Nov 8, 2024
Klakurka
requested changes
Nov 11, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
Actually can you add this into paybutton-generator.html ?
chedieck
requested changes
Nov 12, 2024
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
Adding enable-altpayment="false" doesn't seem to work at the buttons / widgets of paybutton/dev/demo/index.html
Klakurka
approved these changes
Nov 12, 2024
chedieck
approved these changes
Nov 13, 2024
Collaborator
chedieck
left a comment
chedieck
left a comment
There was a problem hiding this comment.
After running yarn clean:build, it worked out well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #422
Description
Created a new prop to enable altpayment logic
Test plan
Create a widget or a paybutton and test prop enable-altpayment="true" and enable-altpayment="false", this prop should control the sideshift logic, it should work on paybutton and widget