-
Notifications
You must be signed in to change notification settings - Fork 16
[UI] Style edits to sideshift UI #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can go further with this IMO:
-
Payment page:
. I think we're using fixed rate we can remove "at least" to make it clear for them to just send that exact amount. Let's make the address copyable - same for the SideShift payment ID. -
If there's only 1 network, which is the case most of the time, let's just hide the network dropdown.
-
I've always thought this looks kinda bad so maybe there's something better we can do to improve the value input here.
-
I don't know why there's a page that asks you to enter an amount again after you've already set the XEC amount before clicking "Don't have any XEC?"... should be removed right?
|
Okay added most of those. What were you referring to in point 4? The amount input? As far as why there is another amount screen, That should only be visible when the altpaymentEditable attribute is set to true, otherwise it should just show the amount |
|
Yeah sorry - I was talking about the amount input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some currencies don't seem to work (no buttons to continue):
Probably need @chedieck to look into it.
|
hmm yeah not sure whats happening there, I can look at the amount input |
|
Updated edit amount input styles |
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Klakurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this for now and we can touch it up after SideShift gets their stuff figured out.



Related to #
Description
Some general UI updates to the sideshift integration
Test plan