[#848] feat: use currency setting #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
requested changes
Nov 13, 2024
Member
Klakurka
left a comment
Klakurka
left a comment
There was a problem hiding this comment.
- When I reset the cache, the lifetime revenue in the dashboard header stopped updated when I would toggle between USD and CAD:
- Tests failing.
Klakurka
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #619
Description
Implements the usage of the user prefered currency.
Test plan
Spin up the containers on master.
Switch the currency of the dev user to CAD. Checking out the dashboard then, should yield no difference.
Checkout to this branch. Still this should yield no difference
Now reset the cache.
yarn docker cr.Finally, the values in the dashboard and elsewhere should all be in CAD instead of USD (thus they will be significantly higher).