Skip to content

Conversation

@PaulThompson
Copy link
Owner

No description provided.

@timbod7
Copy link
Collaborator

timbod7 commented Mar 24, 2025

👍 Thanks for this.

@PaulThompson PaulThompson requested a review from Copilot March 29, 2025 05:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR lays the groundwork for Deno2 by updating core versioning and dependency management while replacing legacy argument parsing with a new CLI module. Key changes include:

  • Bumping the package version to "2.0.0-pre.0" and updating related version references.
  • Replacing Deno’s legacy flags module with a new CLI library and updating import paths accordingly.
  • Updating workflow configurations and adding new tasks (check, lint, fmt) for local verification.

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.ts Version bump to "2.0.0-pre.0".
main.ts Updated imports and replaced flags with cli; switched to async/await syntax for launch.
launch.ts Updated semver API usage and added "--allow-import" flag.
dnit/main.ts Revised import structure using cli and added new tasks.
dnit/deps.ts Updated dependency imports to new URLs and API.
dnit.ts Replaced flags with cli and added override keyword in logging.
deps.ts Updated dependency URLs and imports for improved consistency.
adl-gen/runtime/json.ts Added unknown type annotations in catch clauses.
README.md Updated Denos version requirement and installation command.
.github/workflows/test.yml Upgraded Deno versions and action versions to support Deno2.
Files not reviewed (2)
  • deno.json: Language not supported
  • dnit/.denoversion: Language not supported
Comments suppressed due to low confidence (2)

README.md:19

  • The installation command still references dnit-v1.14.4 while the version in version.ts is updated to "2.0.0-pre.0". Please update the version reference in the README to ensure consistency.
deno install --global --allow-read --allow-write --allow-run -f --name dnit https://deno.land/x/dnit@dnit-v1.14.4/main.ts

launch.ts:118

  • Verify that semver.satisfies accepts the parsed version objects returned by semver.parse() and semver.parseRange(), as this change may affect version comparison behavior.
return semver.satisfies(semver.parse(denoVersion), semver.parseRange(denoReqSemverRange))

@PaulThompson
Copy link
Owner Author

@timbod7 updates for deno2 are working - Do you want to give it a test on your end?

@PaulThompson PaulThompson marked this pull request as ready for review August 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants