-
Notifications
You must be signed in to change notification settings - Fork 6
Work in progress on Deno2 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👍 Thanks for this. |
@std/log is likely to be removed in the future. denoland/std#6124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR lays the groundwork for Deno2 by updating core versioning and dependency management while replacing legacy argument parsing with a new CLI module. Key changes include:
- Bumping the package version to "2.0.0-pre.0" and updating related version references.
- Replacing Deno’s legacy flags module with a new CLI library and updating import paths accordingly.
- Updating workflow configurations and adding new tasks (check, lint, fmt) for local verification.
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.ts | Version bump to "2.0.0-pre.0". |
| main.ts | Updated imports and replaced flags with cli; switched to async/await syntax for launch. |
| launch.ts | Updated semver API usage and added "--allow-import" flag. |
| dnit/main.ts | Revised import structure using cli and added new tasks. |
| dnit/deps.ts | Updated dependency imports to new URLs and API. |
| dnit.ts | Replaced flags with cli and added override keyword in logging. |
| deps.ts | Updated dependency URLs and imports for improved consistency. |
| adl-gen/runtime/json.ts | Added unknown type annotations in catch clauses. |
| README.md | Updated Denos version requirement and installation command. |
| .github/workflows/test.yml | Upgraded Deno versions and action versions to support Deno2. |
Files not reviewed (2)
- deno.json: Language not supported
- dnit/.denoversion: Language not supported
Comments suppressed due to low confidence (2)
README.md:19
- The installation command still references dnit-v1.14.4 while the version in version.ts is updated to "2.0.0-pre.0". Please update the version reference in the README to ensure consistency.
deno install --global --allow-read --allow-write --allow-run -f --name dnit https://deno.land/x/dnit@dnit-v1.14.4/main.ts
launch.ts:118
- Verify that semver.satisfies accepts the parsed version objects returned by semver.parse() and semver.parseRange(), as this change may affect version comparison behavior.
return semver.satisfies(semver.parse(denoVersion), semver.parseRange(denoReqSemverRange))
Can use these without requiring allow-import: https://deno.land/ https://jsr.io/ https://esm.sh/ https://raw.githubusercontent.com https://gist.githubusercontent.com
This reverts commit 1ac690c.
|
@timbod7 updates for deno2 are working - Do you want to give it a test on your end? |
No description provided.