Skip to content
This repository was archived by the owner on Oct 7, 2021. It is now read-only.

Add support for decimal values on set temperature#59

Closed
matitalatina wants to merge 1 commit intoPaulAnnekov:masterfrom
matitalatina:support-decimal-temperature
Closed

Add support for decimal values on set temperature#59
matitalatina wants to merge 1 commit intoPaulAnnekov:masterfrom
matitalatina:support-decimal-temperature

Conversation

@matitalatina
Copy link

This PR is needed for this: home-assistant/core#43970
I added the ability to set a temperature with decimals.

@3v1n0
Copy link

3v1n0 commented Dec 7, 2020

I handled this in #54 a bit differently as if the device has no support for decimal values at all, maybe we don't want to accept non-integer ones, no?

@PaulAnnekov
Copy link
Owner

PaulAnnekov commented Dec 7, 2020

Please, try to come to a consensus on what PR to merge. I don't have any tuya climate device, so I'm not very acknowledged on what problem are you trying to resolve.

@matitalatina
Copy link
Author

We're trying to fix the same issue but differently.
Mine is a more "agnostic" approach. I'm just adding decimal values because some thermostats handle it. I tried with mine and it works, even if I put some decimal value that it doesn't support (e.g 17.7 C), it doesn't get any error, he set the rounded value on the thermostat (17.5).
@3v1n0 tries to do the same but he tries to understand if the device supports halves or not. I don't understand some of his logic, I added some comments on his PR.
We will agree ASAP.

@matitalatina
Copy link
Author

We're putting our effort here #61
I'm closing this one,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants