Skip to content

Comments

Revamp and simplify code, tests, build; add CI/CD#27

Draft
dmyersturnbull wants to merge 14 commits intoPatWalters:masterfrom
dmyersturnbull:master
Draft

Revamp and simplify code, tests, build; add CI/CD#27
dmyersturnbull wants to merge 14 commits intoPatWalters:masterfrom
dmyersturnbull:master

Conversation

@dmyersturnbull
Copy link

Goals: simplify, allow easier programmatic access, stream to output (rather than building up in memory first), enable Unix pipes, optionally or preferentially stream JSON, allow CSV/JSON/TSV everywhere, remove Pandas and dead Python versions, reduce maintenance cost & total amount of code, streamline build, add CI, and publish on PyPi

This should also resolve #9, #14, #16, and #25. This is a draft, and I'd like to make it use stdin and also output JSON rather than text. @PatWalters Let me know what you think!

@PatWalters
Copy link
Owner

This looks great. Thanks for the updates and additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inelegant exit for smiles file with no names

2 participants