dynamically infer many to many primary key types#34
Closed
l0g1x wants to merge 1 commit intoPassionfroot:mainfrom
Closed
dynamically infer many to many primary key types#34l0g1x wants to merge 1 commit intoPassionfroot:mainfrom
l0g1x wants to merge 1 commit intoPassionfroot:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR dynamically infers many-to-many primary key types instead of hardcoding them to string(), and updates the many-to-many join table configuration accordingly.
- Infers primary key types using mapPrismaTypeToZero.
- Introduces explicit checks for primary key existence with clear error messages.
- Refactors relationship definitions to use locally stored primary key fields.
Files not reviewed (1)
- src/tests/snapshots/generator.test.ts.snap: Language not supported
Comments suppressed due to low confidence (2)
src/mappers/schemaMapper.ts:98
- [nitpick] Since modelA_pkField is already verified to exist earlier, consider simplifying to 'destField: [modelA_pkField.name]' for clarity.
destField: modelA_pkField.name ? [modelA_pkField.name] : [],
src/mappers/schemaMapper.ts:104
- [nitpick] Since modelB_pkField is already verified to exist earlier, consider simplifying to 'destField: [modelB_pkField.name]' for clarity.
destField: modelB_pkField.name ? [modelB_pkField.name] : [],
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, many-to-many primary key types where being hardcoded to string()