Open
Conversation
Removed dataclasses dependency from project.
|
I can attest to this. Since this repo requires python 3.10+ then dataclasses should not be a dependency as it is part of the standard library. I cannot add this as a dependency of my repo since it complains about this in pip install. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove broken
dataclassesdependencyThe
dataclasses>=0.8requirement cannot be satisfied on Python 3.10+ because the PyPI backport package was never published above version 0.6 (it was only needed for Python 3.6). Since this project already requirespython >= 3.10, wheredataclassesis part of the standard library, the dependency line serves no purpose and prevents installation: