Fix child invariants checked in super().__init__
#301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we determined the invariants based on the `self` passed to the function. However, in case of `super().__init__`, the invariants that need to be checked after the call are those belonging to to the super class, not the current (child) class. This change fixes the issue by passing in the class corresponding to the invariants alongside function and parameters, so that we can properly resolve which invariants need to be checked. Fixes #300.
mristin
force-pushed
the
mristin/Fix-invariant-of-subclass-applies-to-its-parent
branch
from
62616d1 to
df646dc
Compare
mristin
deleted the
mristin/Fix-invariant-of-subclass-applies-to-its-parent
branch
mristin
added a commit
that referenced
this pull request
Nov 8, 2025
* Fix child invariants checked in ``super().__init__`` (#301) * Support Python 3.13 (#309) * Add support for Python 3.12 (#308) This is a critical bugfix patch version. Previously, we determined the invariants based on the ``self`` passed to the function. However, in case of ``super().__init__``, the invariants that need to be checked after the call are those belonging to to the super class, not the current (child) class. This lead to erroneous invariant checks, where the invariants of the child class where checked after the super-init call in the parent class.
Merged
mristin
added a commit
that referenced
this pull request
Nov 8, 2025
* Fix child invariants checked in ``super().__init__`` (#301) * Support Python 3.13 (#309) * Add support for Python 3.12 (#308) This is a critical bugfix patch version. Previously, we determined the invariants based on the ``self`` passed to the function. However, in case of ``super().__init__``, the invariants that need to be checked after the call are those belonging to to the super class, not the current (child) class. This lead to erroneous invariant checks, where the invariants of the child class where checked after the super-init call in the parent class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we determined the invariants based on the
selfpassed to the function. However, in case ofsuper().__init__, the invariants that need to be checked after the call are those belonging to to the super class, not the current (child) class.This change fixes the issue by passing in the class corresponding to the invariants alongside function and parameters, so that we can properly resolve which invariants need to be checked.
Fixes #300.