Skip to content

Fix README index formatting and refactor JoinRoom method #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LifeRIP merged 2 commits into from
Jun 25, 2025
Merged

Fix README index formatting and refactor JoinRoom method #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7421557
fix: Corrects index formatting in README for consistency
LifeRIP Jun 25, 2025
1909343
refactor: Comment out user permission check in JoinRoom method
LifeRIP Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@

## 📚 Índice

* [🧰 Tecnologías principales](#tecnologías-principales)
* [🗂️ Estructura del Proyecto](#️estructura-del-proyecto)
* [✅ Requisitos](#requisitos)
* [⚙️ Configuración](#configuración)
* [▶️ Ejecución](#️ejecución)
* [📖 Documentación API (Swagger)](#documentación-api-swagger)
* [🔐 Endpoints](#endpoints)
* [🧰 Tecnologías principales](#-tecnologías-principales)
* [🗂️ Estructura del Proyecto](#-estructura-del-proyecto)
* [✅ Requisitos](#-requisitos)
* [⚙️ Configuración](#-configuración)
* [▶️ Ejecución](#-ejecución)
* [📖 Documentación API (Swagger)](#-documentación-api-swagger)
* [🔐 Endpoints](#-endpoints)

* [🟢 Públicos](#-públicos)
* [🔒 Protegidos (requieren token JWT)](#protegidos-requieren-token-jwt)
* [⚙️ Implementación técnica](#implementación-técnica)
* [🔒 Protegidos (requieren token JWT)](#-protegidos-requieren-token-jwt)
* [⚙️ Implementación técnica](#-implementación-técnica)

* [🧩 Firestore](#firestore)
* [🌐 WebSockets](#websockets)
* [💬 Flujo de Chat Directo](#flujo-de-chat-directo)
* [🚧 Desarrollo](#desarrollo)
* [🧩 Firestore](#-firestore)
* [🌐 WebSockets](#-websockets)
* [💬 Flujo de Chat Directo](#-flujo-de-chat-directo)
* [🚧 Desarrollo](#-desarrollo)

---

Expand Down
8 changes: 4 additions & 4 deletions internal/services/room_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ func (s *RoomService) GetAllRooms() ([]models.Room, error) {
// JoinRoom permite a un usuario unirse a una sala si tiene permiso
func (s *RoomService) JoinRoom(roomID string, userID string) error {
// Verificar si el usuario puede unirse a la sala
canJoin := s.RoomRepo.CanJoinRoomWebSocket(roomID, userID)
if !canJoin {
return fmt.Errorf("user is not allowed to join this room")
}
// canJoin := s.RoomRepo.CanJoinRoomWebSocket(roomID, userID)
// if !canJoin {
// return fmt.Errorf("user is not allowed to join this room")
// }

// Añadir usuario a la sala
return s.RoomRepo.AddMemberToRoom(roomID, userID)
Expand Down