-
Notifications
You must be signed in to change notification settings - Fork 1
Math functions for large vector based numbers #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jochen <97750753+Jochengehtab@users.noreply.github.com>
- looping over the hole number - return false at the end
- addBitFromNumber needed as utility - fractional digits are not supported - if the result is 0, an empty vector is returned
Co-authored-by: Jochen <97750753+Jochengehtab@users.noreply.github.com>
Jochengehtab
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request includes several changes to improve the RSA key management and encryption functionality. The key changes involve renaming files and namespaces, adding header guards, and implementing new functions for base64 encoding and decoding.
Key changes:
File Renaming and Namespace Updates:
keys.cpptokey.cppinsrc/CMakeLists.txtand updated corresponding includes and namespace references insrc/cli.cpp,src/cli.h, andsrc/main.cpp. [1] [2] [3] [4]Header Guards:
src/cli.h,src/encryption.h,src/utility.h, andsrc/vec/operations.hto prevent multiple inclusions. [1] [2] [3] [4]Key Management Enhancements:
src/key.cppand updated the key writing and reading functions to usestd::vector<uint8_t>for storing key data. [1] [2]base64Charsfor the base64 character set and updated the key creation and retrieval functions to usestd::vector<uint8_t>insrc/key.h.Code Cleanup:
keys.cppandkeys.hfiles and their contents, as they have been replaced by the newkey.cppandkey.hfiles. [1] [2]Vector Operations:
operationsnamespace insrc/vec/operations.h, including functions for bit manipulation and comparison. [1] [2]Tested platforms
Issue ticket number if there is one