use consistent(qi & di) for Q max computation#7
Merged
ParagEkbote merged 1 commit intoParagEkbote:mainfrom Mar 17, 2026
Merged
Conversation
Contributor
Author
|
@ParagEkbote I intentionally kept them on two separate branches so you could review each change independently and decide what works best. #6 fixes the ts scaling bug (actual impact on accuracy), #7 improves indexing consistency (no impact on output, just cleaner code). If both look good to you, feel free to merge them both. They're independent and don't conflict. |
Owner
|
I understand, thank you for the clarification. LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applied consistency for Q max on a separate branch than the ts removal proposal