[fix] Regional.py: (#88) fixes local to intl mobile_no handling#89
Merged
SaiFi0102 merged 2 commits intoParaLogicTech:version-15from Apr 29, 2025
Merged
Conversation
SaiFi0102
reviewed
Apr 29, 2025
…er starts with 00 to + in local to intl mobile-no handling
SaiFi0102
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix Automatic '+' Prefix in Mobile Number Handling for WhatsApp Integration
This pull request addresses an issue in the WhatsApp integration for ERPNext using Twilio, where the mobile number handling logic automatically prepends a '+' to all mobile numbers. This behavior caused inconsistencies when processing local and international mobile numbers. The fix ensures that the '+' prefix is only added when necessary, based on the number format and country code, improving reliability for both local and international numbers.
Changes Made
'+'only if it's not already present.Why This is Needed
Twilio expects phone numbers in the correct E.164 format. Adding an extra
'+'led to message delivery failures. This fix ensures numbers are properly formatted before being passed to Twilio.Testing
Related Issues
Closes: