Skip to content

fix(customer credit balance report): detail view of outstanding amount, gl wise, sales order wise and delivery note wise #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunhimohamed wants to merge 2 commits into
base: version-15
Choose a base branch
from
Open

fix(customer credit balance report): detail view of outstanding amount, gl wise, sales order wise and delivery note wise #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9faae25
fix(customer credit balance report): detail view of outstanding amoun…
kunhimohamed Mar 30, 2026
f94d0fa
fix(inheritance): reuse the method by the method argument change
kunhimohamed Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions erpnext/selling/doctype/customer/customer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def check_credit_limit(customer, company, ignore_outstanding_sales_order=False,



def get_customer_outstanding(customer, company, ignore_outstanding_sales_order=False, cost_center=None):
def get_customer_outstanding(customer, company, ignore_outstanding_sales_order=False, cost_center=None, no_sum=False):
# Outstanding based on GL Entries

cond = ""
Expand Down Expand Up @@ -530,8 +530,10 @@ def get_customer_outstanding(customer, company, ignore_outstanding_sales_order=F
if flt(dn_item.amount) > flt(si_amount) and dn_item.base_net_total:
outstanding_based_on_dn += ((flt(dn_item.amount) - flt(si_amount)) \
/ dn_item.base_net_total) * dn_item.base_grand_total

return outstanding_based_on_gle + outstanding_based_on_so + outstanding_based_on_dn
if not no_sum:
return outstanding_based_on_gle + outstanding_based_on_so + outstanding_based_on_dn
else:
return outstanding_based_on_gle, outstanding_based_on_so, outstanding_based_on_dn


def get_credit_limit(customer, company):
Expand Down
23 changes: 16 additions & 7 deletions erpnext/selling/report/customer_credit_balance/customer_credit_balance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,26 @@ def execute(filters=None):
for d in customer_list:
row = []

outstanding_amt = get_customer_outstanding(d.name, filters.get("company"),
ignore_outstanding_sales_order=d.bypass_credit_limit_check_at_sales_order)
outstanding_based_on_gle, outstanding_based_on_so, outstanding_based_on_dn = get_customer_outstanding(d.name, filters.get("company"),
ignore_outstanding_sales_order=d.bypass_credit_limit_check, no_sum=True)

total_outstanding_amount = outstanding_based_on_gle+outstanding_based_on_so+outstanding_based_on_dn

credit_limit = get_credit_limit(d.name, filters.get("company"))

bal = flt(credit_limit) - flt(outstanding_amt)
bal = flt(credit_limit) - flt(total_outstanding_amount)

if customer_naming_type == "Naming Series":
row = [d.name, d.customer_name, credit_limit, outstanding_amt, bal,
row = [
d.name, d.customer_name, credit_limit,
outstanding_based_on_gle, outstanding_based_on_so,
outstanding_based_on_dn, total_outstanding_amount, bal,
d.bypass_credit_limit_check, d.is_frozen,
d.disabled]
else:
row = [d.name, credit_limit, outstanding_amt, bal,
d.bypass_credit_limit_check_at_sales_order, d.is_frozen, d.disabled]
row = [d.name, credit_limit, outstanding_based_on_gle, outstanding_based_on_so,
outstanding_based_on_dn, total_outstanding_amount, bal,
d.bypass_credit_limit_check, d.is_frozen, d.disabled]

if credit_limit:
data.append(row)
Expand All @@ -43,7 +49,10 @@ def get_columns(customer_naming_type):
columns = [
_("Customer") + ":Link/Customer:120",
_("Credit Limit") + ":Currency:120",
_("Outstanding Amt") + ":Currency:100",
_("General Ledger Outstanding Amt") + ":Currency:100",
_("Sales Order Outstanding Amt") + ":Currency:100",
_("Delivery Note Outstanding Amt") + ":Currency:100",
_("Total Outstanding Amt") + ":Currency:100",
_("Credit Balance") + ":Currency:120",
_("Bypass credit check at Sales Order ") + ":Check:80",
_("Is Frozen") + ":Check:80",
Expand Down