Skip to content

Fix file import sheet layout and add widget tests #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eoic merged 6 commits into from
Feb 9, 2026
Merged

Fix file import sheet layout and add widget tests #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65c838d
Implement book files metadata parser service.
Eoic Feb 8, 2026
8043508
Add tests for file metadata parser service.
Eoic Feb 8, 2026
14771aa
Fix file import sheet layout and add widget tests.
Eoic Feb 9, 2026
b0cf4ed
Add integration tests for FileImportSheet.show() flow.
Eoic Feb 9, 2026
a02969c
Guard ListView with LayoutBuilder against unbounded width on web.
Eoic Feb 9, 2026
e803470
Remove digital book import flow.
Eoic Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,7 @@ app.*.map.json
/android/app/release

# Config.
google-services.json
google-services.json

# Tests.
test/data/files
Comment on lines +50 to +51
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test/data/files is added to .gitignore, but the new FileMetadataService tests expect files under test/data/files/. Ignoring this directory prevents committing the required fixtures and will make the tests fail for anyone without local copies. Remove this ignore entry or move fixtures to a committed location (or use inlined/generated bytes in tests).

Suggested change
# Tests.
test/data/files
# Tests.

Copilot uses AI. Check for mistakes.
9 changes: 3 additions & 6 deletions client/lib/pages/library_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import 'package:papyrus/widgets/library/book_list_item.dart';
import 'package:papyrus/widgets/library/library_drawer.dart';
import 'package:papyrus/widgets/library/library_filter_chips.dart';
import 'package:papyrus/widgets/search/library_search_bar.dart';
import 'package:papyrus/widgets/add_book/add_book_choice_sheet.dart';
import 'package:papyrus/widgets/shared/empty_state.dart';
import 'package:provider/provider.dart';

Expand Down Expand Up @@ -195,9 +196,7 @@ class _LibraryPageState extends State<LibraryPage> {
),
),
floatingActionButton: FloatingActionButton(
onPressed: () {
// TODO: Add book action
},
onPressed: () => AddBookChoiceSheet.show(context),
child: const Icon(Icons.add),
),
);
Expand Down Expand Up @@ -398,9 +397,7 @@ class _LibraryPageState extends State<LibraryPage> {

Widget _buildAddBookButton(double height) {
return FilledButton.icon(
onPressed: () {
// TODO: Add book action
},
onPressed: () => AddBookChoiceSheet.show(context),
icon: const Icon(Icons.add),
label: const Text('Add book'),
style: FilledButton.styleFrom(minimumSize: Size(0, height)),
Expand Down
Loading
Loading