Skip to content

Conversation

@mightqxc
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Data Carousel system to better handle datasets that reuse existing DDM (Distributed Data Management) rules by:

  • Distinguishing between datasets that are still staging vs. already staged when reusing DDM rules
  • Submitting iDDS (intelligent Data Delivery Service) requests for tasks that reuse existing DDM rules
  • Adding a rescue mechanism for pending tasks with already-completed data carousel requests

Key Changes:

  • Split to_reuse_ds_list into to_reuse_staging_ds_list and to_reuse_staged_ds_list to differentiate staging status
  • Added submit_idds_request parameter to control iDDS request submission when reusing DDM rules
  • Implemented rescue_pending_tasks_with_done_requests() method to update staged files for stuck pending tasks

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pandaserver/taskbuffer/DataCarousel.py Refactored dataset list handling to distinguish staging vs staged rules; added iDDS submission for reused rules; added rescue method for pending tasks; updated _update_staged_files to accept task ID list parameter
pandajedi/jediorder/TaskRefiner.py Updated to use new dataset list variables; properly categorizes already-staged datasets as not needing staging vs still-staging datasets
pandajedi/jedidog/AtlasDataCarouselWatchDog.py Added doRescuePendingTasks method with lock time constant; method is currently commented out in main action loop (staged rollout)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mightqxc mightqxc merged commit c8a69b9 into master Dec 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants