Skip to content

Conversation

@mightqxc
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where datasets reusing existing DDM (Distributed Data Management) rules were incorrectly marked with no_staging=True. The fix ensures these datasets are properly tracked as "staging" datasets rather than "no staging" datasets.

Key Changes:

  • Added to_reuse_ds_list tracking to identify datasets that reuse existing DDM rules
  • Updated logic to add reused datasets to to_staging_datasets instead of leaving them untracked
  • Commented out the code that was adding reused datasets to to_pin_ds_list (not expected in this case)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pandaserver/taskbuffer/DataCarousel.py Adds to_reuse_ds_list to the return map, populates it when existing DDM rules are found, and comments out unexpected to_pin logic for reused rules
pandajedi/jediorder/TaskRefiner.py Adds logic to update to_staging_datasets with datasets from to_reuse_ds_list to prevent them from being incorrectly marked as no_staging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mightqxc mightqxc merged commit 7ba3d3b into master Dec 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants