#525: Update Application Model to Include Relation dac_id WIP #545
+1,301
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nadian-Genome-Library/daco into feat/525-application-model-dac-id
JamesTLopez
requested review from
demariadaniel,
joneubank and
leoraba
and removed request for
demariadaniel
joneubank
reviewed
Jan 21, 2026
Comment on lines
42
to
48
| // Apply backfill with PCGL_DACO_ID | ||
| await transaction | ||
| .update(applications) | ||
| .set({ | ||
| dac_id: `${dbConfig.PCGL_DACO_ID}`, | ||
| }) | ||
| .where(isNull(applications.dac_id)); |
Contributor
There was a problem hiding this comment.
We need an additional filter here to only select applications that are past the submitted for reivew stage (under review, revisions requested, or approved i think?)
Contributor
Author
There was a problem hiding this comment.
I left application state CLOSED out of the backfill as well because technically an applicant can close a application while its still in DRAFT. BUT they can also close it post review stage, so I am unsure whats the more 'correct' option here.
Open to insight
Heres the commit for the update: e7558b1
JamesTLopez
commented
Jan 23, 2026
| "dev:server": "tsx watch --clear-screen=false --env-file=.env ./src/main.ts", | ||
| "dev:watch": "nx watch --projects=@pcgl-daco/api --includeDependentProjects -- nx run-many -t build \\$NX_PROJECT_NAME --exclude=@pcgl-daco/api", | ||
| "dbml": "tsx ./src/db/dbml.ts", | ||
| "migrate:dac-id": "tsx --env-file=.env src/scripts/dac-id-migration.ts", |
Contributor
Author
There was a problem hiding this comment.
naming is hard, open to name suggestions for this script. Or its fine as it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special Instructions
Steps on how to apply the dac_id migrations:
Summary
dac_id migration for the applications model table.
Related Issues
daco_idproperty #525Description of Changes
dac_idinto Application tablePCGL_DACO_IDapplicationentries with nulldac_idwith the PCGL_DAC_ID env varapplicationtable coldac_idto not null.Readiness Checklist
#{TicketNumber}: Description of Changesapi,ui,data-model, etc.)feature,fix,chore,documentation).env.schemafile and documented in the README