feat: add feature neutralization preprocessing#14
Open
MateuszJastrzebski21 wants to merge 1 commit intomainfrom
Open
feat: add feature neutralization preprocessing#14MateuszJastrzebski21 wants to merge 1 commit intomainfrom
MateuszJastrzebski21 wants to merge 1 commit intomainfrom
Conversation
Palamabron
requested changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add feature neutralization preprocessing functionality to the alphapulse package. However, the implementation appears to be incomplete as all three main files added are empty.
- Added pydantic to pre-commit mypy dependencies for type checking support
- Created placeholder files for feature neutralization module, package initialization, and tests (all empty)
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Added pydantic as additional dependency for mypy type checking in both main and notebook hooks |
| src/alphapulse/preprocessing/init.py | Empty file - should contain module exports |
| src/alphapulse/preprocessing/feature_neutralization.py | Empty file - should contain feature neutralization implementation |
| tests/test_feature_neutralization | Empty file with missing .py extension - should contain test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Feature Neutralization preprocessing step.
Changes
Checks