Does this fix a memory leak?#2
Open
grahame-student wants to merge 5 commits intoPacktPublishing:masterfrom
Open
Does this fix a memory leak?#2grahame-student wants to merge 5 commits intoPacktPublishing:masterfrom
grahame-student wants to merge 5 commits intoPacktPublishing:masterfrom
Conversation
Free the memory the person pointer is pointing at. Otherwise when student_dtor() calls person_dtor() the memory will not be released, resulting in a memory leak
Update ExtremeC_examples_chapter8_3_person.c
Revert "Update ExtremeC_examples_chapter8_3_person.c"
Collaborator
|
Hi, sorry for the late reply. I need to look at the example again. Your change seems to be correct and sane but I want to double check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there could be a memory leak in this example. person_dtor() is not freeing the passed in pointer, therefore when student_dtor() calls the base class' destructor the allocated memory is never released.
If I've missed where there memory is freed I would love to know.