API3 rework #9
Open
API3 rework #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reworked things to use API3 and written a few test programs. I still don't have a decent way to test due to the credentials needing to be pushed to travis, so, I wrote a number of small tests that I compared against known results.
I removed quite a bit of the cruft and just used the keys Strava sent back and raise an exception if a key isn't found rather than maintaining a mapping. I have written a small application around this to fetch data and it does get the data as expected. The before/after/page/page_num functionality works and it should mimic everything that it did before.
Some code changes from API1/API2 code will need to be made, but, in the long term, I think the API will be much more maintainable.