Conversation
Merge main into displacement solver
…tej/JustRelax.jl into inj/displacement-solver
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
I will not go forward with this PR. The only purpose of this PR was to check differences between this dev branch and the main branch. @albert-de-montserrat everything looks fine |
|
@inavarretej before closing this, there's a few changes in #357 that will potentially have an impact on your dev branch |
|
@aelligp cool! I'll take a look at them |
|
@inavarretej now you should be able to pull from main |
|
@inavarretej what is l_tau? |
|
Where did you find it? @aelligp |
| rheology::NTuple{N, MaterialParams}, | ||
| phase_ratio, | ||
| r, | ||
| lτ, |
There was a problem hiding this comment.
here, also in PT and compute_U but you dont use it
There was a problem hiding this comment.
Oh I see, I was trying to find a characteristic length to use in the displacement solver, but then I realized I dont need it. I will delete it from the code.
2 participants
Draft of PR. Looking for potential differences between both implementations.