Changed charachter encoding UTF-8 to the HttpSender #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Edward4j Does this change mean one will be able to include emojis in the SMS? |
Author
|
No, I'm not sure about emojis - didn't test it. It is fix for encoding
Norwegian characters like å, ø.
ср, 9 янв. 2019 г. в 16:09, Roger Kind Kristiansen <notifications@github.com
…:
@Edward4j <https://github.com/Edward4j> Does this change mean one will be
able to include emojis in the SMS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFpUjI-mS-dDHUm3PfwadzHF7284CbIDks5vBff9gaJpZM4PIhKX>
.
--
Best regards,
*Eduard Dovgal*
Ruby on Rails Developer
Cell: +38 (067) 405-8314 <+380%2067%20405%208314>
Skype: eduard.dovgal
|
Contributor
|
Hmm, I thought my previous pull request related to the same code fixed that, but my memory of this is pretty weak. But if this ensures UTF-8 when sending to the gateway then with my limited understanding I guess emojis should work as well. 🤔 Might just give this patch a try! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.