Converted NetCoreApp2.0 libs to NetStandard2.0 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes it possible to use the library from other netstandard2.0 libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the PSWinCom client lib from an internal utility DLL, which is netstandard2.0. We get warnings, because the PSWinComGatewayClient is either netcoreapp2.0 or net45.
This PR just exchanges netcoreapp2.0 with netstandard2.0 in the targeting, and runs the tests in both netcoreapp2.1 and net461, to test for both. There is a couple of failing unit tests, but they were failing before the PR too.