-
-
Notifications
You must be signed in to change notification settings - Fork 132
Better handle the pre-time path population distribution #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 72.92% 73.01% +0.09%
==========================================
Files 21 21
Lines 5122 5100 -22
==========================================
- Hits 3735 3724 -11
+ Misses 1387 1376 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
All local tests pass: |
|
When running the OG-USA example (and updating the demographic parameters), I find the following resource constraint issues: OG-Core built from the
|
The population distribution before the start year of the model is necessary to compute savings and bequests in period 0.
This PR adds explicitly the parameters for mortality, immigration, and population growth rates from period 0 to period 1 in order to make for a consistent transition from this "pre model period" to period 0.
cc @rickecon