Skip to content

Fix menu flicker #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkalkbrenner merged 11 commits into from
Mar 17, 2026
Merged

Fix menu flicker #132

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
333f7e5
test if f close is causing flicker
PastorL69 Mar 13, 2026
9910b3f
remove flicker, test
PastorL69 Mar 14, 2026
407a7e8
try with clearscreen
PastorL69 Mar 14, 2026
3aab2f0
Why do we have this?
PastorL69 Mar 14, 2026
eb65ea8
prepare for new method of saving values
PastorL69 Mar 14, 2026
5198288
save values when exiting the menu instead of directly when changing t…
PastorL69 Mar 16, 2026
60fd5a3
lock USB for pico builds
PastorL69 Mar 16, 2026
aa7764d
correct one
PastorL69 Mar 16, 2026
3c7bfa6
only return USB
PastorL69 Mar 16, 2026
955ac51
add back else
PastorL69 Mar 16, 2026
c1ba9b8
white space......
PastorL69 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,9 @@ static uint8_t NormalizeTransportType(uint8_t type) {
? type
: Transport::WIFI_UDP;
#elif defined(ZEDMD_NO_NETWORKING)
return type == Transport::SPI ? Transport::SPI : Transport::USB;
return Transport::USB;
#else
return type <= Transport::SPI ? type : Transport::USB;
return Transport::USB;
#endif
}

Expand Down Expand Up @@ -776,6 +776,7 @@ void AcquireNextBuffer() {
void CheckMenuButton() {
#ifndef DISPLAY_RM67162_AMOLED
if (!digitalRead(FORWARD_BUTTON_PIN)) {
ClearScreen();
settingsMenu = true;
SaveSettingsMenu();
delay(20);
Expand Down Expand Up @@ -2061,7 +2062,7 @@ void setup() {
} else {
if (position == 3) position = forward ? 4 : 2;
}
#ifdef DMDREADER
#if defined (DMDREADER) || defined(PICO_BUILD)
if (position == 5) position = forward ? 6 : 4;
#endif

Expand Down Expand Up @@ -2147,6 +2148,15 @@ void setup() {
if (up || down) {
switch (position) {
case 1: { // Exit
ClearScreen();
SaveLum();
SaveRgbOrder();
#if defined(ARDUINO_ESP32_S3_N16R8) || defined(PICO_BUILD)
SaveUsbPackageSizeMultiplier();
SaveDebug();
#elif (DMDREADER)
SaveColor();
#endif
Restart();
break;
}
Expand All @@ -2158,7 +2168,6 @@ void setup() {

display->SetBrightness(brightness);
DisplayLum(255, 191, 0);
SaveLum();
break;
}
case 3: { // USB Package Size
Expand All @@ -2170,7 +2179,6 @@ void setup() {
DisplayNumber(usbPackageSizeMultiplier * 32, 4,
7 * (TOTAL_WIDTH / 128) + (16 * 4),
(TOTAL_HEIGHT / 2) + 4, 255, 191, 0);
SaveUsbPackageSizeMultiplier();
break;
}
#ifdef DMDREADER
Expand All @@ -2187,7 +2195,6 @@ void setup() {
display->DisplayText(ColorString(loopbackColor),
7 * (TOTAL_WIDTH / 128) + (6 * 4),
TOTAL_HEIGHT / 2 + 4, 255, 191, 0);
SaveColor();
break;
}
#else
Expand Down Expand Up @@ -2233,7 +2240,6 @@ void setup() {
if (++debug > 1) debug = 0;
DisplayNumber(debug, 1, 7 * (TOTAL_WIDTH / 128) + (6 * 4),
(TOTAL_HEIGHT / 2) - 10, 255, 191, 0);
SaveDebug();
break;
}
case 7: { // RGB order
Expand All @@ -2251,7 +2257,6 @@ void setup() {
rgbMode = 5;
RefreshSetupScreen();
DisplayRGB(255, 191, 0);
SaveRgbOrder();
break;
}
case 8: { // LED Test
Expand Down
Loading