new interpolator #615
Draft
new interpolator #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
This should be rebased or cherrypicked to merge into |
Contributor
|
@philipp-rajah I linked Issue#86 to this PR. We stated back then that maybe we could resolve that issue and its sub-issues with this interpolator rewrite, so we should check that we can resolve them here. |
Contributor
|
Linked Issue#419 to this PR. There it is suggested that we might find a solution to fix a possible classification issue that can lead HMS-HMS stars to result in RLO. An example there finds a system that entered unstable_MT during step_HMS_HMS, which should lead to step_CE, not step_detached (which would be valid as a result of stable MT). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft PR for the initial final interpolator rewrite which includes numerous improvements to the code, both at the preprocessing and the algorithmic levels.