Skip to content

Unit tests for popsyn module #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
elizabethteng wants to merge 16 commits into
base: v2.2
Choose a base branch
from
Draft

Unit tests for popsyn module #499

elizabethteng wants to merge 16 commits into from

Conversation

@elizabethteng
Copy link
Contributor

@elizabethteng elizabethteng commented Jan 30, 2025 •
edited
Loading

Priorities:

  • test_io.py
  • test_rate_calculation.py
  • test_synthetic_population.py
    • PopulationRunner
    • DFInterface
    • History
    • Oneline
    • PopulationIO (changed by Max PR)
    • Population (reworked by Max PR)
    • TransientPopulation (reworked by Max PR)
    • Rates
  • test_transient_select_funcs.py

Others:

  • test_analysis.py
  • test_binarypopulation.py
  • test_defaults.py
  • test_GRB.py
  • test_independent_sample.py fix name of binary_fraction_value to generate_binary_fraction
  • test_sample_from_file.py
  • test_selection_effects.py
  • test_star_formation_history.py

@elizabethteng elizabethteng self-assigned this Jan 30, 2025
@elizabethteng elizabethteng marked this pull request as draft January 30, 2025 15:53
@mkruckow mkruckow added the enhancement New feature or request label Feb 4, 2025
@mkruckow mkruckow mentioned this pull request Apr 3, 2025
Merged
@maxbriel
Copy link
Collaborator

maxbriel commented Apr 29, 2025

I've excluded get_formation_times in star_formation_history in PR #543 but this function should be tested :)

@elizabethteng elizabethteng marked this pull request as ready for review July 16, 2025 19:28
@elizabethteng elizabethteng marked this pull request as draft July 16, 2025 19:28
@elizabethteng elizabethteng changed the base branch from development to v2.1-dev July 29, 2025 22:23
@sgossage sgossage mentioned this pull request Oct 3, 2025
Closed
@elizabethteng elizabethteng changed the base branch from v2.1-dev to v2.2 October 30, 2025 14:28
@elizabethteng elizabethteng changed the base branch from v2.2 to main October 30, 2025 14:43
@elizabethteng elizabethteng changed the base branch from main to v2.2 October 30, 2025 14:43
@elizabethteng
Copy link
Contributor Author

elizabethteng commented Oct 30, 2025

successfully fixed rebase, now I need to go back and copy over changes from v2.2 from Max's pops PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@elizabethteng elizabethteng

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elizabethteng @maxbriel @mkruckow