Skip to content

Develop#60

Open
joeflack4 wants to merge 9 commits intoPMA-2020:developfrom
joeflack4:develop
Open

Develop#60
joeflack4 wants to merge 9 commits intoPMA-2020:developfrom
joeflack4:develop

Conversation

@joeflack4
Copy link
Contributor

If this pull request addresses any open issues, please link them here.

What has been done to verify that this works as intended?

How could this contribution be further improved? Were any other approaches considered?

- Fixed an issue where new datasets could not be uploaded.
- Fixed an issue where, when a non API dataset file or a malformed API dataset file was uploaded, and a cryptic error message was displayed instead of something helpful.

Developer updates
- Moved dropzone.js link to a CDN.
- Added dropzone.js CSS link.

Updates
- On the /admin page, dataset activation buttons are no longer disabled if there is an actively running task. This is to prevent possible contingencies where there is a hanging / erroneously registered as active task running in the background and therefore locking down the UI. This should also allow users to effectively cancel a running task if they want to and either restart it or start activation on another dataset.
…n portal not currently being supported. Fixed a test where, depending on the environment, there was an unanticipated type related error.
Troubleshooting failing tests. Effectively now all the tests are either: (a) not working, or (b) not needed. So I commented out the entire test file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant