Add printer for Env.t for debugging#180
Draft
ProgMiner wants to merge 1 commit intoPLTools:masterfrom
Draft
Conversation
Signed-off-by: Eridan Domoratskiy <eridan200@mail.ru>
Kakadu
requested changes
Jun 18, 2025
Collaborator
Kakadu
left a comment
There was a problem hiding this comment.
I think is PR is not consequent.
It doesn't give any useful API (IMHO), but introduced a function which is never used. In one of last PRs you were removing functions which are not used anywhere, why the one should remove these function in the next PR?
Contributor
Author
|
I've used these functions while debugging an error message "OCanren fatal (Env.check): wrong environment". It's true, that they aren't helpful without any other changes (e.g. printing environment in IMO, any type must provide pretty-printing functions even if they aren't used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.