Open
Conversation
The QR-Code requires the title to be in front of the name seperated by ':' to be displayed in apps like Authy
|
This PR contains an error - it is using The problem it attempts to fix is valid and the solution seems reasonable aside from the above (though I would avoid inline short-form if statements in complex expressions and split it out into a normal if() condition to update |
|
Note that PR #80 contains an alternative solution to the same problem, though it also suffers from the double-escaping issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QR-Code requires the title to be in front of the name seperated by ':' to be displayed in apps like Authy