there have a bug, resolved.

[adotpeng]

getCode method return value is blank

[PHPGangsta]

Hello,

can you please explain where the bug exactly is? Why does getCode() not return the correct value? It works since years.
Maybe you changed my class and activated strict_types or so? That might fail, because str_pad() expects a string as first parameter, but the modulo-operation gives an int value.
But that only happens if you changed my class/file, and activated strict_types for it.
Or is there another problem with the code you are fixing?

Why did you introduce the variables $secretLen and $eightBitsLen, they are not needed I think. Can you please explain why you introduced them?

Thanks

[adotpeng]

i am sorry, i used strict_types. thanks for your reminder.

[MarkMaldaba]

This PR should be closed. As far as I can see (and as per the above discussion) there is no issue here to fix, as strict_types is not enabled for this library.