Update function getQRCodeGoogleUrl in GoogleAuthenticator.php to be compliant with PHP 8.3#113
Open
vmanrc wants to merge 3 commits intoPHPGangsta:masterfrom
Open
Update function getQRCodeGoogleUrl in GoogleAuthenticator.php to be compliant with PHP 8.3#113vmanrc wants to merge 3 commits intoPHPGangsta:masterfrom
vmanrc wants to merge 3 commits intoPHPGangsta:masterfrom
Conversation
Make the returned URL compliant with PHP 8.3: put curly brackets around variables.
Update name and version
Update name and remove comma from homepage
|
Notwithstanding the apparent abandoned status of this project, this PR can't be merged unless the changes to The code fix is good, however, and is worth applying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the URL returned by function getQRCodeGoogleUrl() compliant with PHP 8.3:
put curly brackets around variables.