Open
Conversation
|
Please merge this fix; I ran into this problem this week, tracked it down to in_array() not using strict mode. If your options contains something like ['some_key' => true], the plugin will not add the $aliasedField . 'IS NULL' to the query and include deleted records in the results, even though 'withDeleted' is not present in the array. Using strict for in_array resolves this problem. |
|
+1 |
|
In case anyone needs this, I've made my own package: $ composer require nedgen/cakephp3-soft-delete dev-master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the 'strict' option for 'in_array'
http://php.net/manual/en/function.in-array.php