Skip to content

Conversation

@EncVar
Copy link
Contributor

@EncVar EncVar commented Sep 14, 2025

blah

@EncVar EncVar requested a review from pynickle September 14, 2025 06:37
@pynickle pynickle requested a review from Copilot September 14, 2025 14:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the task system by creating a base non-generic TaskBase class and restructuring task hierarchies for improved flexibility and performance. The changes enable better handling of different return types and simplify task management.

  • Introduces a non-generic TaskBase base class with TaskBase<TResult> inheriting from it
  • Refactors PipelineTask to inherit from TaskGroup instead of TaskBase directly
  • Adds support for multiple parameter passing through PipelineReturnList in pipeline tasks

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File Description
App/Tasks/TaskGroup.cs New abstract class implementing task grouping functionality with IList interface
App/Tasks/TaskBase.cs Refactored to create base non-generic class with generic version inheriting from it
App/Tasks/PipelineTask.cs Updated to inherit from TaskGroup and improved parameter handling with new return list type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@EncVar
Copy link
Contributor Author

EncVar commented Nov 1, 2025

rebase炸掉了.jpg

@EncVar EncVar requested review from a team and whitecat346 January 3, 2026 12:31
Copy link
Member

@whitecat346 whitecat346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他的:

  • 既然你都用集合表达式了就一用到底,混着new和集合表达式过于操蛋
  • 我不太清楚为何创建一个PipelineReturnList,这个就是个List<object?>别名,没啥必要吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.