-
Notifications
You must be signed in to change notification settings - Fork 20
perf: task #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
perf: task #79
Conversation
…into feat/task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the task system by creating a base non-generic TaskBase class and restructuring task hierarchies for improved flexibility and performance. The changes enable better handling of different return types and simplify task management.
- Introduces a non-generic
TaskBasebase class withTaskBase<TResult>inheriting from it - Refactors
PipelineTaskto inherit fromTaskGroupinstead ofTaskBasedirectly - Adds support for multiple parameter passing through
PipelineReturnListin pipeline tasks
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| App/Tasks/TaskGroup.cs | New abstract class implementing task grouping functionality with IList interface |
| App/Tasks/TaskBase.cs | Refactored to create base non-generic class with generic version inheriting from it |
| App/Tasks/PipelineTask.cs | Updated to inherit from TaskGroup and improved parameter handling with new return list type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* perf(java): 优化目录搜索部分性能 * feat: 支持从 where 指令输出中获取 Java * fix(java): 可能会由于乱序列表导致选择错误的 Java
在启动设置中选择了 IP 偏好后,将会同时添加 `-Djava.net.preferIPvXAddresses=true`
* imp: 再次优化了 MotD 的显示效果 * 优化部分代码
|
rebase炸掉了.jpg |
whitecat346
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他的:
- 既然你都用集合表达式了就一用到底,混着new和集合表达式过于操蛋
- 我不太清楚为何创建一个
PipelineReturnList,这个就是个List<object?>别名,没啥必要吧
blah