Karianna's fork of Vests gh_build PR

.github/agents/my-code-review-agent.md

@@ -0,0 +1,8 @@
+---
+name: Code Review Agent
+description: Agent that specilises in code reviews, digging into the why of the change.
+---
+
+# My Agent
+
+Agent that specilises in code reviews, digging into the why of the change.

.github/agents/my-security-agent.md

@@ -0,0 +1,8 @@
+---
+name: Security Review Agent
+description: Security Review Agent
+---
+
+# My Agent
+
+Reviews the code for security vulnerabilities and bad coding practices.

.github/workflows/gradle-release.yml

@@ -0,0 +1,106 @@
+name: Create Release
+
+on:
+  push:
+    tags:
+      - "v*.*.*"
+
+permissions:
+  contents: write
+
+jobs:
+  create_release:
+    name: Create Release
+    runs-on: ubuntu-latest
+    steps:
+      - name: Create Release
+        id: create_release
+        uses: softprops/action-gh-release@v2
+        with:
+          name: ${{ github.ref_name }}
+          draft: false
+          prerelease: false
+          generate_release_notes: false
+
+  build_release:
+    name: Build Release
+    needs: create_release
+    strategy:
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest]
+        include:
+          - os: ubuntu-latest
+            release_suffix: ubuntu
+          - os: ubuntu-24.04-arm
+            release_suffix: ubuntu-arm
+          - os: macos-latest
+            release_suffix: mac
+          - os: windows-latest
+            release_suffix: windows
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up JDK 25
+        uses: actions/setup-java@v4
+        with:
+          java-version: '25'
+          distribution: 'temurin'
+          cache: gradle
+          cache-dependency-path: |
+            build.gradle
+            code/gradle/autobuild.gradle
+            code/gradle/distribution.gradle
+            code/gradle/release.gradle
+            code/gradle/reporting.gradle
+            code/gradle/plugins.gradle
+
+      # Configure Gradle for optimal use in GitHub Actions, including caching of downloaded dependencies.
+      # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+        with:
+          cache-disabled: false
+          cache-read-only: false
+          cache-overwrite-existing: true
+
+      - uses: actions/cache@v4
+        with:
+          path: |
+            ${{ github.workspace }}/build/jre
+            ${{ github.workspace }}/build/libs
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+          restore-keys: |
+            ${{ matrix.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+            ${{ matrix.os }}-gradle
+
+      - name: Build the image
+        if: success()
+        run: ./gradlew jpackage
+
+      - name: Upload release assets for macos
+        uses: actions/upload-artifact@v4
+        if: matrix.os == 'macos-latest'
+        with:
+          name: ${{ matrix.os }}
+          path: ${{ github.workspace }}/build/jpackage/*.dmg
+
+      - name: Upload release assets for ubuntu
+        uses: actions/upload-artifact@v4
+        if: matrix.os == 'ubuntu-latest'
+        with:
+          name: ${{ matrix.os }}
+          path: ${{ github.workspace }}/build/jpackage/*.deb
+
+      - name: Upload release assets for windows
+        uses: actions/upload-artifact@v4
+        if: matrix.os == 'windows-latest'
+        with:
+          name: ${{ matrix.os }}
+          path: ${{ github.workspace }}/build/jpackage/*.msi
+
+      - name: Release - ${{ matrix.os }}
+        uses: softprops/action-gh-release@v2
+        with:
+          tag_name: ${{ needs.create_release.outputs.tag-name }}
+          files: ${{ github.workspace }}/build/jpackage/pcgen-*.*

.github/workflows/gradle-test.yml

@@ -0,0 +1,91 @@
+# This workflow will build a Java project with Gradle and cache/restore any dependencies to improve the workflow execution time
+# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-gradle
+
+name: Build PCGen with Gradle
+
+on:
+  pull_request:
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    permissions:
+      checks: write
+      pull-requests: write
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up JDK 25
+        uses: actions/setup-java@v4
+        with:
+          java-version: '25'
+          distribution: 'temurin'
+          cache: gradle
+          cache-dependency-path: |
+            build.gradle
+            code/gradle/autobuild.gradle
+            code/gradle/distribution.gradle
+            code/gradle/release.gradle
+            code/gradle/reporting.gradle
+            code/gradle/plugins.gradle
+
+      # Configure Gradle for optimal use in GitHub Actions, including caching of downloaded dependencies.
+      # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+        with:
+          cache-disabled: false
+          cache-read-only: false
+          cache-overwrite-existing: true
+
+      - uses: actions/cache@v4
+        with:
+          path: |
+            ${{ github.workspace }}/build/jre
+            ${{ github.workspace }}/build/libs
+          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+          restore-keys: |
+            ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
+            ${{ runner.os }}-gradle
+
+      - name: Build with Gradle Wrapper
+        run: ./gradlew build
+
+      - name: Run tests
+        run: ./gradlew test itest datatest slowtest
+
+      - name: Publish Test Results
+        uses: EnricoMi/publish-unit-test-result-action@v2
+        if: always()
+        with:
+          files: |
+            build/test-results/**/*.xml
+            build/test-results/**/*.trx
+            build/test-results/**/*.json
+
+      - name: Run Coverage
+        run: ./gradlew testCoverage
+
+      - name: Upload Report to artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: testCoverage
+          path: ${{ github.workspace }}/build/reports/jacoco/testCoverage/html
+
+      - name: Jacoco Report to PR
+        id: jacoco
+        uses: madrapps/jacoco-report@v1.7.2
+        with:
+          paths: |
+            ${{ github.workspace }}/build/reports/jacoco/testCoverage/testCoverage.xml
+          token: ${{ secrets.GITHUB_TOKEN }}
+          title: '## :construction: PCGen Code Coverage'
+          update-comment: true
+          debug-mode: false
+
+      - name: Get the Coverage info
+        run: |
+          echo "Total coverage ${{ steps.jacoco.outputs.coverage-overall }}"
+          echo "Changed Files coverage ${{ steps.jacoco.outputs.coverage-changed-files }}"

.gitignore

@@ -5,6 +5,8 @@
 .settings/
 /settings/
 
+testsuite/
+
 # Batch converter
 batch-convert.jar
 
@@ -94,6 +96,7 @@ code/build.eclipse/
 
 # IntelliJ IDE
 .idea/
+.run/
 out/
 pcgendev.iml
 pcgen.iml

PCGen-Formula/code/standards/suppressions.xml → PCGen-Formula/code/standards/checkstyle-suppressions.xml

@@ -1,10 +1,8 @@
 <?xml version="1.0"?>
-
 <!DOCTYPE suppressions PUBLIC
-    "-//Puppy Crawl//DTD Suppressions 1.1//EN"
-    "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+    "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+    "https://checkstyle.org/dtds/suppressions_1_2.dtd">
 
 <suppressions>
     <suppress checks=".*" files=".*pcgen.base.formula.parse.*"/>
 </suppressions>
-

PCGen-Formula/code/standards/checkstyle.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
-
+<!DOCTYPE module PUBLIC
+        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+        "https://checkstyle.org/dtds/configuration_1_3.dtd">
 <!--
     This configuration file was written by the eclipse-cs plugin configuration editor
 -->
@@ -83,12 +84,8 @@
   </module>
   <module name="NewlineAtEndOfFile"/>
   <module name="Translation"/>
-
-
     <module name="SuppressWarningsFilter"/>
-
 	<module name="SuppressionFilter">
-		<property name="file" value="${suppressionFile}" default="suppressions.xml"/>
+		<property name="file" value="${suppressionFile}" default="checkstyle-suppressions.xml"/>
 	</module>
-
 </module>

PCGen-Formula/code/standards/spotbugs_ignore.xml

@@ -9,8 +9,8 @@
         <Bug pattern="SE_NO_SERIALVERSIONID,SE_COMPARATOR_SHOULD_BE_SERIALIZABLE,SE_BAD_FIELD" />
    </Match>
    <Match>
-        <!-- not relevent to pcgen -->
-        <Bug pattern="IJU_SETUP_NO_SUPER,DP_DO_INSIDE_DO_PRIVILEGED,DM_EXIT" />
+        <!-- not relevant to pcgen -->
+        <Bug pattern="IJU_SETUP_NO_SUPER,DP_DO_INSIDE_DO_PRIVILEGED" />
     </Match>
     <Match>
         <!-- we have other tools for code style -->

PCGen-Formula/gradle/reporting.gradle

@@ -8,7 +8,7 @@
 
 checkstyle {
 	configFile = new File('code/standards/checkstyle.xml')
-	configProperties = [ "suppressionFile" : project(':').file('code/standards/suppressions.xml')]
+	configProperties = [ "suppressionFile" : project(':').file('code/standards/checkstyle-suppressions.xml')]
 	ignoreFailures = true
 	showViolations = false
 	sourceSets = []
@@ -31,4 +31,6 @@ spotbugs {
 	toolVersion = "3.1.8"
 }
 
-task allReports { dependsOn = ['checkstyleMain', 'pmdMain', 'spotbugsMain'] }
+tasks.register('allReports') {
+    dependsOn = ['checkstyleMain', 'pmdMain', 'spotbugsMain']
+}

PCGen-base/code/standards/checkstyle.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
-
+<!DOCTYPE module PUBLIC
+        "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+        "https://checkstyle.org/dtds/configuration_1_3.dtd">
 <!--
     This configuration file was written by the eclipse-cs plugin configuration editor
 -->

PCGen-base/code/standards/spotbugs_ignore.xml

@@ -9,8 +9,8 @@
         <Bug pattern="SE_NO_SERIALVERSIONID,SE_COMPARATOR_SHOULD_BE_SERIALIZABLE" />
    </Match>
    <Match>
-        <!-- not relevent to pcgen -->
-        <Bug pattern="IJU_SETUP_NO_SUPER,DP_DO_INSIDE_DO_PRIVILEGED,DM_EXIT" />
+        <!-- not relevant to pcgen -->
+        <Bug pattern="IJU_SETUP_NO_SUPER,DP_DO_INSIDE_DO_PRIVILEGED" />
     </Match>
     <Match>
         <!-- we have other tools for code style -->